Raise best practice violation if ":" in container name #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendichter
reviewed
Nov 27, 2024
bendichter
approved these changes
Nov 27, 2024
Co-authored-by: Ben Dichter <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
bendichter
reviewed
Nov 28, 2024
Co-authored-by: Ben Dichter <[email protected]>
|
Tests will fail until the new HDMF release which allows a user to create an object with "/" or ":" in the name in construct mode only. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #532 +/- ##
===========================================
- Coverage 82.71% 58.81% -23.91%
===========================================
Files 47 47
Lines 1510 1515 +5
===========================================
- Hits 1249 891 -358
- Misses 261 624 +363
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Related to hdmf-dev/hdmf-zarr#219 and hdmf-dev/hdmf#1202